Mailing-List: contact issues-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@struts.apache.org
Date: Mon, 28 Jul 2014 15:18:40 +0000 (UTC)
From: "Lukasz Lenart (JIRA)" <jira@apache.org>
To: issues@struts.apache.org
Message-ID: <JIRA.12453340.1254063347222.56559.1406560720132@arcas>
In-Reply-To: <JIRA.12453340.1254063347222@arcas>
References: <JIRA.12453340.1254063347222@arcas>
Subject: [jira] [Updated] (WW-3266) getFieldValue() method of
 ValueStackDataSource uses getDescription() to get field value may not
 appropriate
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/WW-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukasz Lenart updated WW-3266:
------------------------------

    Fix Version/s:     (was: 2.3.18)
                   2.5

> getFieldValue() method of ValueStackDataSource uses getDescription() to get field value may not appropriate
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3266
>                 URL: https://issues.apache.org/jira/browse/WW-3266
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - JasperReports
>    Affects Versions: 2.1.6
>         Environment: JasperReports 3.6
> Groovy 1.5.5
> JDK 1.6 (MAC JDK) 
>            Reporter: Matt Jiang
>             Fix For: 2.5
>
>
> Current implementation:
> {code:java}
> String expression = field.getDescription();
> if (expression == null) {
>     //Description is optional so use the field name as a default
>     expression = field.getName();
> }
> Object value = valueStack.findValue(expression);
> {code}
> Recommended implementation :
> {code:java}
> String expression = field.getName();
> Object value = valueStack.findValue(expression);
> {code}
> Reason:
> In JasperReports, a description of a field is just like a documentation for this field. So it may not good to use it as expression.


--
This message was sent by Atlassian JIRA
(v6.2#6252)