struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4350) OgnlValueStack causes race condition
Date Fri, 11 Jul 2014 08:00:21 GMT

    [ https://issues.apache.org/jira/browse/WW-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14058528#comment-14058528
] 

Hudson commented on WW-4350:
----------------------------

SUCCESS: Integrated in Struts-JDK6-develop #60 (See [https://builds.apache.org/job/Struts-JDK6-develop/60/])
WW-4350 Solves problem with race condition (lukaszlenart: rev 7e477b956bd8d57597b649014a20d0d69fae1ce0)
* xwork-core/src/main/java/com/opensymphony/xwork2/ognl/accessor/CompoundRootAccessor.java


> OgnlValueStack causes race condition
> ------------------------------------
>
>                 Key: WW-4350
>                 URL: https://issues.apache.org/jira/browse/WW-4350
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Actions, Value Stack
>    Affects Versions: 2.3.16.1
>            Reporter: Sergey Gromov
>            Assignee: Lukasz Lenart
>             Fix For: 2.3.18
>
>         Attachments: CompoundRootAccessor.java.patch
>
>
> _com.opensymphony.xwork2.ognl.accessor.CompoundRootAccessor.callMethod_ is not thread
safe because of unsynchronized reads and writes to HashMap:
> {code}
> private static Map invalidMethods = new HashMap();
> ...
> public Object callMethod(Map context, Object target, String name, Object[] objects) throws
MethodFailedException {
>     ...
>     if ((argTypes == null) || !invalidMethods.containsKey(mc)) {
>         ...
>         invalidMethods.put(mc, Boolean.TRUE);
>         ...
>     }
>     ...
> }
> {code}
> Propose to use _ConcurrentHashMap_



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message