struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4318) Logging message when OgnlValueStack fail to set expression is cryptic most of the time
Date Tue, 29 Jul 2014 18:32:40 GMT

    [ https://issues.apache.org/jira/browse/WW-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078129#comment-14078129
] 

Hudson commented on WW-4318:
----------------------------

SUCCESS: Integrated in Struts-JDK6-develop #66 (See [https://builds.apache.org/job/Struts-JDK6-develop/66/])
WW-4318 Uses ErrorMessageBuilder to proper log fail of setting expression (lukaszlenart: rev
5c4874c60bb5331258e4a415af8604afaf1242b5)
* xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java


> Logging message when OgnlValueStack fail to set expression is cryptic most of the time
> --------------------------------------------------------------------------------------
>
>                 Key: WW-4318
>                 URL: https://issues.apache.org/jira/browse/WW-4318
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Value Stack
>    Affects Versions: 2.3.16.1
>            Reporter: Brendan Le Ny
>            Assignee: Lukasz Lenart
>            Priority: Trivial
>              Labels: logging
>             Fix For: 2.3.18
>
>         Attachments: WW-4318.patch
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> Most of the time, the logging message printed by OgnlValueStack class is useless because
it doesn't show the value that causes the problem.
> Exemple log:
> {quote}
> 2014/03/20 02:23:28  WARN (CommonsLogger.java:64) warn Error setting expression 'myIntField'
with value '[Ljava.lang.String;@55227e4a'
> ognl.MethodFailedException: Method "setMyIntField" failed for object fr.my.company.MyAction@df39b8b4
[java.lang.NoSuchMethodException: fr.my.company.MyAction@df39b8b4.setMyIntField([Ljava.lang.String;)]
> {quote}
> I can't find the reason because toString() is on a array show  '[Ljava.lang.String;@55227e4a'
but i would like to see the actual value in the array.
> The exact same problem is fixed right in the method above the buggy one: the trivial
patch is included.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message