struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lukasz Lenart (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-3266) getFieldValue() method of ValueStackDataSource uses getDescription() to get field value may not appropriate
Date Mon, 28 Jul 2014 15:18:39 GMT

    [ https://issues.apache.org/jira/browse/WW-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076293#comment-14076293
] 

Lukasz Lenart commented on WW-3266:
-----------------------------------

This can be a breaking change, someone can base on that - I'm going postpone this change.

> getFieldValue() method of ValueStackDataSource uses getDescription() to get field value
may not appropriate
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3266
>                 URL: https://issues.apache.org/jira/browse/WW-3266
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - JasperReports
>    Affects Versions: 2.1.6
>         Environment: JasperReports 3.6
> Groovy 1.5.5
> JDK 1.6 (MAC JDK) 
>            Reporter: Matt Jiang
>             Fix For: 2.5
>
>
> Current implementation:
> {code:java}
> String expression = field.getDescription();
> if (expression == null) {
>     //Description is optional so use the field name as a default
>     expression = field.getName();
> }
> Object value = valueStack.findValue(expression);
> {code}
> Recommended implementation :
> {code:java}
> String expression = field.getName();
> Object value = valueStack.findValue(expression);
> {code}
> Reason:
> In JasperReports, a description of a field is just like a documentation for this field.
So it may not good to use it as expression.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message