Return-Path: X-Original-To: apmail-struts-issues-archive@minotaur.apache.org Delivered-To: apmail-struts-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 33B9F119F2 for ; Fri, 27 Jun 2014 11:42:25 +0000 (UTC) Received: (qmail 50115 invoked by uid 500); 27 Jun 2014 11:42:25 -0000 Delivered-To: apmail-struts-issues-archive@struts.apache.org Received: (qmail 50089 invoked by uid 500); 27 Jun 2014 11:42:24 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 50077 invoked by uid 99); 27 Jun 2014 11:42:24 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jun 2014 11:42:24 +0000 Date: Fri, 27 Jun 2014 11:42:24 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (WW-4346) Nested visitor validator returns wrong full field name MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WW-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14045844#comment-14045844 ] ASF subversion and git services commented on WW-4346: ----------------------------------------------------- Commit 3a07c317724c1f8017be93f0e1bae23392c08fc6 in struts's branch refs/heads/develop from [~lukaszlenart] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=3a07c31 ] WW-4346 Solves problem with nested visitor validator returns wrong full field name Closes #13 > Nested visitor validator returns wrong full field name > ------------------------------------------------------ > > Key: WW-4346 > URL: https://issues.apache.org/jira/browse/WW-4346 > Project: Struts 2 > Issue Type: Bug > Reporter: Aleksandr Mashchenko > Labels: patch > Fix For: 2.3.18 > > Attachments: tests-visitor-full-field-name.diff, visitor-full-field-name.diff > > > Original issue report: http://stackoverflow.com/questions/23544452/chaining-visitor-validator-in-struts-2. > This bug can be reproduced by nesting two or more visitor validators with a conversion validator in the last validation configuration. > Conversion validator in nested visitor validators doesn't work as expected because getFullFieldName method in VisitorFieldValidator.AppendingValidatorContext returns not a full field name. > This patch makes sure that the correct full field name is returned. > Also the InternalValidatorContextWrapper-s from AnnotationActionValidatorManager and DefaultActionValidatorManager could be removed because they were introduced to fix similar issue with nested visitor validators. See https://issues.apache.org/jira/browse/XW-588 and https://issues.apache.org/jira/browse/XW-618 for more details. -- This message was sent by Atlassian JIRA (v6.2#6252)