struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4360) Fix potential NullPointerExceptions in xwork-core
Date Sat, 28 Jun 2014 07:02:24 GMT

    [ https://issues.apache.org/jira/browse/WW-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14046787#comment-14046787
] 

ASF GitHub Bot commented on WW-4360:
------------------------------------

Github user lukaszlenart commented on a diff in the pull request:

    https://github.com/apache/struts/pull/16#discussion_r14322940
  
    --- Diff: xwork-core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
---
    @@ -425,7 +427,7 @@ protected void addAction(Element actionElement, PackageConfig.Builder
packageCon
             } else {
                 if (!verifyAction(className, name, location)) {
                     if (LOG.isErrorEnabled())
    -                    LOG.error("Unable to verify action [#0] with class [#1], from [#2]",
name, className, location.toString());
    +                    LOG.error("Unable to verify action [#0] with class [#1], from [#2]",
name, className, ObjectUtils.toString(location));
    --- End diff --
    
    I prefer extending `Logger` interface and define new method: `void error(String msg, Object...
args);` the same as I already did for `debug` and `trace`. Thus will allow reduce `ObjectUtils`
dependency and give new functionality :-)
    
    This can be handled with dedicated PR


> Fix potential NullPointerExceptions in xwork-core
> -------------------------------------------------
>
>                 Key: WW-4360
>                 URL: https://issues.apache.org/jira/browse/WW-4360
>             Project: Struts 2
>          Issue Type: Bug
>            Reporter: Joseph Walton
>            Priority: Minor
>             Fix For: 2.3.18
>
>
> Eclipse's static analysis of nulls identifies a number of spots in xwork-core where a
NullPointerException can occur. This change fixes them either to rearrange things so they
can't happen or to throw a more specific exception.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message