struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4360) Fix potential NullPointerExceptions in xwork-core
Date Wed, 11 Jun 2014 15:06:02 GMT

    [ https://issues.apache.org/jira/browse/WW-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14027846#comment-14027846
] 

ASF GitHub Bot commented on WW-4360:
------------------------------------

GitHub user josephw opened a pull request:

    https://github.com/apache/struts/pull/16

     WW-4360: Fix a few NullPointerExceptions identified by Eclipse #15 

    Eclipse's static analysis of nulls identifies a number of spots where a NullPointerException
can occur. This change fixes them either to rearrange things so they can't happen or to throw
a more specific exception.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/josephw/struts master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16
    
----
commit 81cdd6e0d8fe01616e5c3055e5536ee63199b6e6
Author: Joseph Walton <jwalton@atlassian.com>
Date:   2014-06-10T12:21:39Z

    Clean up potential NullPointerExceptions.
    
    - Construct BufferedReaders ahead of try blocks
    - Don't catch exceptions in tests
    - Specifically check for mismatched braces in patterns
    - Fail on an unknown numeric type

commit f98e92c154add1c869efe88ce1fdba984a5f71aa
Author: Joseph Walton <jwalton@atlassian.com>
Date:   2014-06-10T12:21:55Z

    Fix potential NullPointerExceptions.
    
    - Allow for a null location when logging
    - Don't try to use a null LocationFinder

----


> Fix potential NullPointerExceptions in xwork-core
> -------------------------------------------------
>
>                 Key: WW-4360
>                 URL: https://issues.apache.org/jira/browse/WW-4360
>             Project: Struts 2
>          Issue Type: Bug
>            Reporter: Joseph Walton
>            Priority: Minor
>
> Eclipse's static analysis of nulls identifies a number of spots in xwork-core where a
NullPointerException can occur. This change fixes them either to rearrange things so they
can't happen or to throw a more specific exception.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message