struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lukasz Lenart (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (WW-4354) ParametersInterceptor's isWithinLengthLimit() method ignores devMode
Date Wed, 28 May 2014 12:04:01 GMT

     [ https://issues.apache.org/jira/browse/WW-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Lukasz Lenart updated WW-4354:
------------------------------

    Description: 
In the Class com.opensymphony.xwork2.interceptor.ParametersInterceptor
the method isWithinLengthLimit( String name ) does not consider the *devMode* flag.

{code}
protected boolean isWithinLengthLimit( String name ) {
        boolean matchLength = name.length() <= paramNameMaxLength;
        if (!matchLength) {
            notifyDeveloper("Parameter [#0] is too long, allowed length is [#1]", name, String.valueOf(paramNameMaxLength));
        }
        return matchLength;
}
{code}

As a result, an ERROR is logged when a Paramter is too long.
E.g.
[com.opensymphony.xwork2.interceptor.ParametersInterceptor] [Developer Notification (set struts.devMode
to false to disable this message):
Unexpected Exception caught setting '****' on 'class java.lang.String: 100]

  was:
In the Class com.opensymphony.xwork2.interceptor.ParametersInterceptor
the method isWithinLengthLimit( String name ) does not consider the *devMode* flag.

{code}
protected boolean isWithinLengthLimit( String name ) {
        boolean matchLength = name.length() <= paramNameMaxLength;
        if (!matchLength) {
            notifyDeveloper("Parameter [#0] is too long, allowed length is [#1]", name, String.valueOf(paramNameMaxLength));
        }
        return matchLength;
	}
{code}

As a result, an ERROR is logged when a Paramter is too long.
E.g.
[com.opensymphony.xwork2.interceptor.ParametersInterceptor] [Developer Notification (set struts.devMode
to false to disable this message):
Unexpected Exception caught setting '****' on 'class java.lang.String: 100]


> ParametersInterceptor's isWithinLengthLimit() method ignores devMode
> --------------------------------------------------------------------
>
>                 Key: WW-4354
>                 URL: https://issues.apache.org/jira/browse/WW-4354
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 2.3.16.3
>            Reporter: Andreas Wolf
>             Fix For: 2.3.18
>
>
> In the Class com.opensymphony.xwork2.interceptor.ParametersInterceptor
> the method isWithinLengthLimit( String name ) does not consider the *devMode* flag.
> {code}
> protected boolean isWithinLengthLimit( String name ) {
>         boolean matchLength = name.length() <= paramNameMaxLength;
>         if (!matchLength) {
>             notifyDeveloper("Parameter [#0] is too long, allowed length is [#1]", name,
String.valueOf(paramNameMaxLength));
>         }
>         return matchLength;
> }
> {code}
> As a result, an ERROR is logged when a Paramter is too long.
> E.g.
> [com.opensymphony.xwork2.interceptor.ParametersInterceptor] [Developer Notification (set
struts.devMode to false to disable this message):
> Unexpected Exception caught setting '****' on 'class java.lang.String: 100]



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message