struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Gromov (JIRA)" <j...@apache.org>
Subject [jira] [Created] (WW-4350) OgnlValueStack causes race condition
Date Wed, 21 May 2014 12:13:37 GMT
Sergey Gromov created WW-4350:
---------------------------------

             Summary: OgnlValueStack causes race condition
                 Key: WW-4350
                 URL: https://issues.apache.org/jira/browse/WW-4350
             Project: Struts 2
          Issue Type: Bug
          Components: Core Actions, Value Stack
    Affects Versions: 2.3.16.1
            Reporter: Sergey Gromov


_com.opensymphony.xwork2.ognl.accessor.CompoundRootAccessor.callMethod_ is not thread safe
because of unsynchronized reads and writes to HashMap:
{code}
private static Map invalidMethods = new HashMap();
...
public Object callMethod(Map context, Object target, String name, Object[] objects) throws
MethodFailedException {
    ...
    if ((argTypes == null) || !invalidMethods.containsKey(mc)) {
        ...
        invalidMethods.put(mc, Boolean.TRUE);
        ...
    }
    ...
}
{code}

Propose to use _ConcurrentHashMap_



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message