struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4344) Improve Logging layer implementation to avoid additional boilerplate with if (LOG.isDebugEnable)
Date Sun, 11 May 2014 02:37:14 GMT

    [ https://issues.apache.org/jira/browse/WW-4344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13994401#comment-13994401
] 

Paul Benedict commented on WW-4344:
-----------------------------------

What logging framework are we using? Is it SLF4J? If we use log4j2, it's even easier:
http://logging.apache.org/log4j/2.x/manual/api.html

> Improve Logging layer implementation to avoid additional boilerplate with if (LOG.isDebugEnable)
> ------------------------------------------------------------------------------------------------
>
>                 Key: WW-4344
>                 URL: https://issues.apache.org/jira/browse/WW-4344
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: "New" API
>    Affects Versions: 2.3.16.3
>            Reporter: Lukasz Lenart
>            Assignee: Lukasz Lenart
>              Labels: logging
>             Fix For: 2.3.18
>
>
> Instead using
> {code:java}
> if (LOG.isDebugEnable()) {
>      LOG.debug("Action name is [#0]', actionName);
> }
> {code}
> can be reduced to 
> {code:java}
> LOG.debug("Action name is [#0]', actionName);
> {code}
> with implementation in {{JdkLogger}} and any other implementation of {{Logger}} interface:
> {code:java}
> public void debug(String message, String... params) {
>     if(isDebugEnable()) {
>          // perform logging
>     }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message