Return-Path: X-Original-To: apmail-struts-issues-archive@minotaur.apache.org Delivered-To: apmail-struts-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E06E5110BB for ; Fri, 25 Apr 2014 08:09:20 +0000 (UTC) Received: (qmail 75469 invoked by uid 500); 25 Apr 2014 08:09:20 -0000 Delivered-To: apmail-struts-issues-archive@struts.apache.org Received: (qmail 74967 invoked by uid 500); 25 Apr 2014 08:09:19 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 74828 invoked by uid 99); 25 Apr 2014 08:09:18 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Apr 2014 08:09:18 +0000 Date: Fri, 25 Apr 2014 08:09:18 +0000 (UTC) From: "Lukasz Lenart (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (WW-4332) refine excludeParams of ParametersInterceptor to improve security MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WW-4332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980785#comment-13980785 ] Lukasz Lenart commented on WW-4332: ----------------------------------- Please open new request > refine excludeParams of ParametersInterceptor to improve security > ------------------------------------------------------------------ > > Key: WW-4332 > URL: https://issues.apache.org/jira/browse/WW-4332 > Project: Struts 2 > Issue Type: Improvement > Components: Core Interceptors > Affects Versions: 2.3.16.1 > Reporter: zhouyanming > Assignee: Lukasz Lenart > Priority: Critical > Fix For: 2.3.16.2 > > > {code} > (.*\.|^)class\..* > {code} > should be > {code} > (.*\.|^)class(\.|\[).*,.*\['class'\](\.|\[).*,.*\["class"\](\.|\[).* > {code} > it will block such as > {code}class['classLoader'] , model['class'].classLoader , model["class"].classLoader {code} > I think use regex to block parameterName is not best solution,It must be done in ValueStack, seperate entry point , one for serverside, one for client side,client side should add more restriction and security checks. -- This message was sent by Atlassian JIRA (v6.2#6252)