Mailing-List: contact issues-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@struts.apache.org
Date: Wed, 26 Mar 2014 02:21:15 +0000 (UTC)
From: "Jose L Martinez-Avial (JIRA)" <jira@apache.org>
To: issues@struts.apache.org
Message-ID: <JIRA.12703640.1395796653034.6107.1395800475286@arcas>
In-Reply-To: <JIRA.12703640.1395796653034@arcas>
References: <JIRA.12703640.1395796653034@arcas>
Subject: [jira] [Commented] (WW-4311) HttpHeaderResult should allow to
 provide a body for the response
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/WW-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947468#comment-13947468 ] 

Jose L Martinez-Avial commented on WW-4311:
-------------------------------------------

Actually, taking a look at the code. I think we also need to change the status to be an String,instead of an int, and make it parseable. This way it would behave the same way as the error/errorMessage fields. The main difference I see is that there is a constructor HttpHeaderResult(int status), and it would be impacted. Is that constructor used somewhere?

> HttpHeaderResult should allow to provide a body for the response
> ----------------------------------------------------------------
>
>                 Key: WW-4311
>                 URL: https://issues.apache.org/jira/browse/WW-4311
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Dispatch Filter
>            Reporter: Jose L Martinez-Avial
>            Priority: Minor
>
> Curently the HttpHeaderResult can only write to the body response if it is the result has a parameter error (through the errorMessage setter), and then it uses javax.servlet.http.HttpServletResponse#sendError(int, String) to send the error, with the error message in the body, to the client.
> If the result has a parameters status, and no error, then nothing is written to the response body. It only set the status and the headers, and send it to the client.
> I suggest to add a parameter message that can be written to the response when using the parameter status.
> I'm working on a patch for this, it shouldn't take long.


--
This message was sent by Atlassian JIRA
(v6.2#6252)