struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "adam brin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4295) provide better documentation and / or functionality for localization of struts2 tag elements (select, radio, etc.)
Date Mon, 03 Mar 2014 21:14:20 GMT

    [ https://issues.apache.org/jira/browse/WW-4295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918577#comment-13918577
] 

adam brin commented on WW-4295:
-------------------------------

note, the code example is not the best, there should be a better way to get at the getText()
method than the calling the text freemarker parameter. It might be worth optionally pairing
the listKey parameter with a "prefix" that is used in the lookup to further distinguish the
value.  

> provide better documentation and / or functionality for localization of struts2 tag elements
(select, radio, etc.)
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-4295
>                 URL: https://issues.apache.org/jira/browse/WW-4295
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.3.16
>            Reporter: adam brin
>
> The <@s.text> macro is very useful for localization of text values.  The <@s.textfield
tag also takes a "key" > but, the select, radio, and checkbox options don't have good options
for localization.  One option raised on the list and identified in a few places is to construct
a separate map of variables that have been localized in Freemarker and use that for localization
(https://stackoverflow.com/questions/5548104/struts-select-tag-localization-implementation/17258640#17258640)...
this does not seem sustainable or maintainable. Two possible methods for addressing this might
be:
> # update the documentation to better identify how to localize these values in the "approved"
way
> # implement a listKey parameter that like the textfield implementation or other implementations
might call getText() on the key prior to rendering
> {code:title=Example Implementation for Radiobutton}
>     <#if parameters.listKey??>
>         <#assign itemValue><@s.text name="${stack.findString(parameters.listKey)}"
/><#rt></#assign>    
>     <#elseif parameters.listValue??>
>         <#assign itemValue = stack.findString(parameters.listValue)/>
>     <#else>
>         <#assign itemValue = stack.findString('top')/>
>     </#if>
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message