Return-Path: X-Original-To: apmail-struts-issues-archive@minotaur.apache.org Delivered-To: apmail-struts-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BBF3C103C9 for ; Fri, 10 Jan 2014 06:19:10 +0000 (UTC) Received: (qmail 88482 invoked by uid 500); 10 Jan 2014 06:19:07 -0000 Delivered-To: apmail-struts-issues-archive@struts.apache.org Received: (qmail 88398 invoked by uid 500); 10 Jan 2014 06:18:55 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 88356 invoked by uid 99); 10 Jan 2014 06:18:50 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Jan 2014 06:18:50 +0000 Date: Fri, 10 Jan 2014 06:18:50 +0000 (UTC) From: "Lukasz Lenart (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (WW-4274) DefaultActionInvocation shows invalid log MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WW-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-4274: ------------------------------ Fix Version/s: 2.3.17 > DefaultActionInvocation shows invalid log > ------------------------------------------ > > Key: WW-4274 > URL: https://issues.apache.org/jira/browse/WW-4274 > Project: Struts 2 > Issue Type: Improvement > Components: Core Actions > Reporter: Jose L Martinez-Avial > Priority: Trivial > Fix For: 2.3.17 > > Attachments: WW-4274.patch > > > The method invokeAction of com.opensymphony.xwork2.DefaultActionInvocation logs the following line for each action it executes: > DEBUG com.opensymphony.xwork2.DefaultActionInvocation - Executing action method = null > I was curious about why the method was null, and find the following: > {code:title=DefaultActionInvocation.java|borderStyle=solid} > protected String invokeAction(Object action, ActionConfig actionConfig) throws Exception { > String methodName = proxy.getMethod(); > if (LOG.isDebugEnabled()) { > LOG.debug("Executing action method = " + actionConfig.getMethodName()); > } > [...] > {code} > but it does not use actionConfig.getMethodName() at all. It uses methodName, from proxy.getMethod(). And actionConfig.getMethodName() is null if no method was declared on the action definition (then it uses the standard execute). I believe that the log should be modified to show methodName instead if actionConfig.getMethodName(). I'm sending attached a patch for this issue. -- This message was sent by Atlassian JIRA (v6.1.5#6160)