struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4271) Improve loggign level in JSONUtil to avoid excessive logs
Date Wed, 08 Jan 2014 12:03:52 GMT

    [ https://issues.apache.org/jira/browse/WW-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865354#comment-13865354
] 

ASF subversion and git services commented on WW-4271:
-----------------------------------------------------

Commit 1556509 from [~lukaszlenart] in branch 'struts2/trunk'
[ https://svn.apache.org/r1556509 ]

WW-4271 Improves pattern logging in JSONUtil

> Improve loggign level in JSONUtil to avoid excessive logs
> ---------------------------------------------------------
>
>                 Key: WW-4271
>                 URL: https://issues.apache.org/jira/browse/WW-4271
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - JSON
>    Affects Versions: 2.3.16
>            Reporter: Jose L Martinez-Avial
>            Priority: Trivial
>             Fix For: 2.3.17
>
>         Attachments: WW-4271.patch
>
>
> The JSON result type generates excessive logs when used in debug mode, since it shows
a log for each pattern defined in the result, and a log for the final result. For example:
> DEBUG org.apache.struts2.json.JSONUtil  - Adding include property expression:  actionMessages.*
> DEBUG org.apache.struts2.json.JSONUtil  - Adding include property expression:  actionResult
> DEBUG org.apache.struts2.json.JSONUtil  - Adding include property expression:  data.*
> DEBUG org.apache.struts2.json.JSONUtil  - Adding include property expression:  fieldErrors.*
> DEBUG org.apache.struts2.json.JSONUtil  - [JSON]{"actionMessages":[],"actionResult":"success","data":{},"fieldErrors":{}}
> It would be better to change the level used in the method addPattern to trace, since
in debug mode the final result is quite more useful than the "Adding include". I'm attaching
a patch for this.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message