struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4259) Parameter is NULL when Submitting form with parameters using URL contains querystring consisted of some fields
Date Sun, 19 Jan 2014 15:33:20 GMT

    [ https://issues.apache.org/jira/browse/WW-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875879#comment-13875879
] 

ASF subversion and git services commented on WW-4259:
-----------------------------------------------------

Commit 1cc2d67826698f6a95582570d5104a10f55976dc in branch refs/heads/master from [~phillips1021]
[ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=1cc2d67 ]

See JIRA:  https://issues.apache.org/jira/browse/WW-4259

Change to ServletUrlRenderer to not escape an & twice when a query string in included
in the s:form tags action attribute (e.g. action="TestAction?field1=one&field2=two"

Added a test for this use case to FormTagTest.java

> Parameter is NULL when Submitting form with parameters using URL contains querystring
consisted of some fields
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-4259
>                 URL: https://issues.apache.org/jira/browse/WW-4259
>             Project: Struts 2
>          Issue Type: Bug
>         Environment: Struts: 2.3.16
> JRE: 7.0
> Tomcat: 7.0
>            Reporter: Yorozuya Kazuyuki
>            Assignee: Bruce Phillips
>            Priority: Minor
>             Fix For: 2.3.17
>
>         Attachments: ServletUrlRenderer.java.patch, formtest-0.0.1-SNAPSHOT.war, formtest.zip
>
>
> h3. Phenomenon
> 1. Submitting form with parameters using URL contains querystring consisted of some fields.
> {noformat}
> <s:form id="testForm" action="Test.action?field1=%{field1}&field2=%{field2}">
> {noformat}
> Field1, field2 are member of Test class.
> Each setter is implemented in this class.
> \\
> 2. When form tag in struts is interpreted as in HTML, "action" atrribute is this.
> {noformat}
> action="Test.action?field1=value1&amp;amp;field2=value2"
> {noformat}
> Due to duplication of "amp;", it causes field2 member to fail to recieve value.
> therefore, field2 member equals NULL always.
>  
> \\
> Desired result 2. is this.
> {noformat}
> action="Test.action?field1=value1&amp;field2=value2"
> {noformat}
> \\
> h3. Cause
> Character entity reference about "&" is executed twice.
> Executed points are as follow.
> --------------------------------------------------------------------------------
> ・/core/src/main/java/org/apache/struts2/views/util/DefaultUrlHelper.java
> {noformat}
> String buildUrl(
>  String action, HttpServletRequest request, HttpServletResponse response, 
>  Map<String, Object> params, String scheme, boolean includeContext,
>  boolean encodeResult, boolean forceAddSchemeHostAndPort, boolean escapeAmp
> )
> {noformat}
> ・/core/src/main/resources/template/simple/form-common.ftl
> {noformat}
> <#if parameters.action??>
>   action="${parameters.action?html}"<#rt/>
> </#if>
> {noformat}
> --------------------------------------------------------------------------------
> h3. Solution
> "escapeAmp" in method "DefaultUrlHelper.buildUrl" is set false. 
> My patch file is attached.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message