struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Johno Crawford (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4264) notifyDeveloper method logs error even when devMode is set false
Date Thu, 26 Dec 2013 23:45:50 GMT

    [ https://issues.apache.org/jira/browse/WW-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13857161#comment-13857161
] 

Johno Crawford commented on WW-4264:
------------------------------------

2.3.16 / trunk. I can assure you it does not. The methods notifyDeveloper(String message,
String... parameters) and notifyDeveloper(Object action, String property, String message)
are conflicting.

notifyDeveloper("Parameter [#0] is too long, allowed length is [#1]", name, String.valueOf(paramNameMaxLength));
invokes the latter method which does not have a devMode check.

> notifyDeveloper method logs error even when devMode is set false
> ----------------------------------------------------------------
>
>                 Key: WW-4264
>                 URL: https://issues.apache.org/jira/browse/WW-4264
>             Project: Struts 2
>          Issue Type: Bug
>            Reporter: Johno Crawford
>            Assignee: Bruce Phillips
>            Priority: Minor
>
> notifyDeveloper(Object action, String property, String message) is called from com.opensymphony.xwork2.interceptor.ParametersInterceptor#acceptableName
without checking devMode boolean.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message