Mailing-List: contact issues-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@struts.apache.org
Date: Sat, 7 Sep 2013 13:27:52 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: issues@struts.apache.org
Message-ID: <JIRA.12667448.1378557437299.96911.1378560472445@arcas>
In-Reply-To: <JIRA.12667448.1378557437299@arcas>
References: <JIRA.12667448.1378557437299@arcas>
Subject: [jira] [Commented] (WW-4193) OGNL WARN msg in log when user  enters
 invalid data
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/WW-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13761021#comment-13761021 ] 

ASF subversion and git services commented on WW-4193:
-----------------------------------------------------

Commit 1520763 from [~rgielen] in branch 'struts2/trunk'
[ https://svn.apache.org/r1520763 ]

WW-4193 - Patch by Christoph Nenning
With this patch it is checked if devMode is active and if logMissingProperties is enabled before the exception is logged
- refactored shouldLogNoSuchPropertyWarning() to shouldLogMissingPropertyWarning() and using it to handle MethodFailedExceptions.
- updated void handleOgnlException(String expr, Object value, boolean throwExceptionOnFailure, OgnlException e) to use it.
                
> OGNL WARN msg in log when user  enters invalid data
> ---------------------------------------------------
>
>                 Key: WW-4193
>                 URL: https://issues.apache.org/jira/browse/WW-4193
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Expression Language, Value Stack
>    Affects Versions: 2.3.15.1
>            Reporter: Christoph Nenning
>            Assignee: Rene Gielen
>            Priority: Minor
>             Fix For: 2.3.16
>
>         Attachments: struts2.patch
>
>
> When a user enters a invalid value, the framework logs a WARN msg with stacktrace. Even when dev mode is disabled.
> For example:
> - an Action with an int as member
> - a form with a text field for that int
> - user enters a string
> The framework tries to find a setter for that member (which is successful) and tries to set the value (which fails because the setter has wrong parameter type)
> Then a stracktrace is logged as WARN.
> It is a valid use case that users enter invalid data and no stracktrace should be logged (at least not when dev mode is disabled).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira