struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <>
Subject [jira] [Commented] (WW-4193) OGNL WARN msg in log when user enters invalid data
Date Sat, 07 Sep 2013 13:41:52 GMT


Hudson commented on WW-4193:

SUCCESS: Integrated in Struts2-JDK6 #789 (See [])
WW-4193 - Patch by Christoph Nenning
With this patch it is checked if devMode is active and if logMissingProperties is enabled
before the exception is logged
- refactored shouldLogNoSuchPropertyWarning() to shouldLogMissingPropertyWarning() and using
it to handle MethodFailedExceptions.
- updated void handleOgnlException(String expr, Object value, boolean throwExceptionOnFailure,
OgnlException e) to use it. (rgielen: rev 1520763)
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/ognl/

> OGNL WARN msg in log when user  enters invalid data
> ---------------------------------------------------
>                 Key: WW-4193
>                 URL:
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Expression Language, Value Stack
>    Affects Versions:
>            Reporter: Christoph Nenning
>            Assignee: Rene Gielen
>            Priority: Minor
>             Fix For: 2.3.16
>         Attachments: struts2.patch
> When a user enters a invalid value, the framework logs a WARN msg with stacktrace. Even
when dev mode is disabled.
> For example:
> - an Action with an int as member
> - a form with a text field for that int
> - user enters a string
> The framework tries to find a setter for that member (which is successful) and tries
to set the value (which fails because the setter has wrong parameter type)
> Then a stracktrace is logged as WARN.
> It is a valid use case that users enter invalid data and no stracktrace should be logged
(at least not when dev mode is disabled).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message