struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rene Gielen (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (WW-3651) Struts 2 is calling response.setLocale even though it will not handle the request
Date Wed, 18 Sep 2013 07:00:54 GMT

    [ https://issues.apache.org/jira/browse/WW-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13770516#comment-13770516
] 

Rene Gielen edited comment on WW-3651 at 9/18/13 6:59 AM:
----------------------------------------------------------

I thing not calling setLocale has the side effect of, well, not setting the response locale.
It will _only_ have a side effect on encoding if not character encoding is set so far:
{code}
It also sets the response's character encoding appropriately for the locale, 
if the character encoding has not been explicitly set using setContentType
or setCharacterEncoding, getWriter hasn't been called yet, and the response
hasn't been committed yet.
{code}

Setting the locale is really important to our framework users. Serving static resource with
various encodings on the other hand is not the usual 80% use case. I think you should chose
out of these two:

1. use UTF-8 all the way, and set {{struts.i18n.encoding=UTF-8}}. This should take precedence
over the encoding side effect of setLocale - if not, this is a bug to address.
2. place your custom filter after StrutsPrepareFilter and address the encoding issues you
are facing as you specifically need it

I really recommend option 1, UTF-8 is the only true source nowadays :)
But dropping setLocale is really not what we want.
                
      was (Author: rgielen):
    I thing not calling setLocale has the side effect of, well, not setting the response locale.
It will _only_ have a side effect on encoding if not character encoding is set so far:
{code}
It also sets the response's character encoding appropriately for the locale, if the character
encoding has not been explicitly set using setContentType or setCharacterEncoding, getWriter
hasn't been called yet, and the response hasn't been committed yet.
{code}

Setting the locale is really important to our framework users. Serving static resource with
various encodings on the other hand is not the usual 80% use case. I think you should chose
out of these two:

1. use UTF-8 all the way, and set {{struts.i18n.encoding=UTF-8}}. This should take precedence
over the encoding side effect of setLocale - if not, this is a bug to address.
2. place your custom filter after StrutsPrepareFilter and address the encoding issues you
are facing as you specifically need it

I really recommend option 1, UTF-8 is the only true source nowadays :)
But dropping setLocale is really not what we want.
                  
> Struts 2 is calling response.setLocale even though it will not handle the request
> ---------------------------------------------------------------------------------
>
>                 Key: WW-3651
>                 URL: https://issues.apache.org/jira/browse/WW-3651
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Dispatch Filter
>    Affects Versions: 2.2.3
>         Environment: Windows 7, Java 1.6
>            Reporter: Alfredo Osorio
>             Fix For: 2.3.16
>
>
> The org.apache.struts2.dispatcher.ng.filter.StrutsPrepareFilter --> org.apache.struts2.dispatcher.Dispatcher.prepare(HttpServletRequest
request, HttpServletResponse response) is calling response.setLocale(locale) when you specify
a default locale (using struts.properties struts.locale). This is wrong because consider the
following example:
> This is a static resource stored in the following path: www.mydomain.com/myApp/scripts/utils.js
where myApp is the webcontext and /scripts/utils.js is a java script file.
> 1. A request to /myApp/scripts/utils.js.
> 1. Even though Struts 2 is not going to handle the request org.apache.struts2.dispatcher.ng.filter.StrutsPrepareFilter
calls prepare.setEncodingAndLocale(request, response);
> which sets the Request Encoding and the Response Locale.
> 2. Servlet Container Response setLocale obtains the character encoding corresponding
to that locale and assign a character encoding to the response. This behavior is correct according
to the spec: http://download.oracle.com/javaee/5/api/javax/servlet/ServletResponse.html#setLocale%28java.util.Locale%29
> 3. Struts Execute filter doesn't handle the request so chain.doFilter(request, response);
is called.
> 4. Once all filters are called the servlet container DefaultServlet is called to handle
the request and send the content of the file assigning the response header Content-Type in
which this case it will use the encoding type that was set before by the StrutsPrepareFilter.
This might not correspond to the actual encoding of the file.
> An example of the Header Response Content-Type:
> Content-Type	application/x-javascript;charset=ISO-8859-1
> This only happens when you specify the default locale in the struts.properties because
of these lines in Dispatcher.prepare():
> {code:java}
> String encoding = null;
> if (defaultEncoding != null) {
>     encoding = defaultEncoding;
> }
> Locale locale = null;
> if (defaultLocale != null) {
>     locale = LocalizedTextUtil.localeFromString(defaultLocale, request.getLocale());
> }
> {code}
> 		
> I think that locale = LocalizedTextUtil.localeFromString(defaultLocale, request.getLocale());
should be removed because setting locale will set the character encoding. And this has side
effects when requests are made to static resources.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message