Return-Path: X-Original-To: apmail-struts-issues-archive@minotaur.apache.org Delivered-To: apmail-struts-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 14AA91067F for ; Tue, 30 Jul 2013 20:15:49 +0000 (UTC) Received: (qmail 99132 invoked by uid 500); 30 Jul 2013 20:15:48 -0000 Delivered-To: apmail-struts-issues-archive@struts.apache.org Received: (qmail 99092 invoked by uid 500); 30 Jul 2013 20:15:48 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 99084 invoked by uid 99); 30 Jul 2013 20:15:48 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Jul 2013 20:15:48 +0000 Date: Tue, 30 Jul 2013 20:15:48 +0000 (UTC) From: "Lukasz Lenart (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (WW-4145) file.ftl in xhtml theme directly references xhtml controlfooter.ftl MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WW-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13724345#comment-13724345 ] Lukasz Lenart commented on WW-4145: ----------------------------------- I thought you're using {{ThreadLocal}} to cache resolved themes/template paths. Anyway, can you prepare a fully working patch against trunk? Then I will be able to review your solution. > file.ftl in xhtml theme directly references xhtml controlfooter.ftl > ------------------------------------------------------------------- > > Key: WW-4145 > URL: https://issues.apache.org/jira/browse/WW-4145 > Project: Struts 2 > Issue Type: Bug > Components: Other > Affects Versions: 2.3.15.1 > Reporter: Jasper Rosenberg > Assignee: Lukasz Lenart > Labels: freemarker, tags, xhtml > Fix For: 2.3.16 > > > Should use $\{parameters.theme} instead so can be used in theme extension. > {code} > <#include "/${parameters.templateDir}/${parameters.theme}/controlheader.ftl" /> > <#include "/${parameters.templateDir}/simple/file.ftl" /> > <#include "/${parameters.templateDir}/${parameters.theme}/controlfooter.ftl" /> > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira