Mailing-List: contact issues-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@struts.apache.org
Date: Thu, 18 Jul 2013 13:34:48 +0000 (UTC)
From: "Lukasz Lenart (JIRA)" <jira@apache.org>
To: issues@struts.apache.org
Message-ID: <JIRA.12658517.1374153756164.72812.1374154488720@arcas>
In-Reply-To: <JIRA.12658517.1374153756164@arcas>
References: <JIRA.12658517.1374153756164@arcas>
Subject: [jira] [Commented] (WW-4144) Have ObjectFactory buildResult obey
 ParameterNameAware restrictions for a Result
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/WW-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13712325#comment-13712325 ] 

Lukasz Lenart commented on WW-4144:
-----------------------------------

You use exactly the same {{ParameterNameAware}} interface as for actions? What do you do if Result doesn't implement {{ParameterNameAware}}? And do you use that? Wrap each predefined Result with your custom implementation?
                
> Have ObjectFactory buildResult obey ParameterNameAware restrictions for a Result
> --------------------------------------------------------------------------------
>
>                 Key: WW-4144
>                 URL: https://issues.apache.org/jira/browse/WW-4144
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Actions
>    Affects Versions: 2.3.15.1
>            Reporter: Jasper Rosenberg
>            Priority: Minor
>              Labels: ObjectFactory
>             Fix For: 2.3.16
>
>
> com.opensymphony.xwork2.ObjectFactory#buildResult(ResultConfig, Map), injects all of the resultConfig parameters into the result after it has been built.  
> However, I'd like to be able to have my Result implement ParameterNameAware, and then have buildResult obey its acceptableParameterName() result so I can filter out what parameters can be injected.
> I'm sorry I don't have a proper patch, but it is a very small change.  Only call setProperty on the result if it is not ParameterNameAware, or it is and the parameter name is acceptable.
> {code:java} 
> if ((!(result instanceof ParameterNameAware)) || (((ParameterNameAware) result).acceptableParameterName(paramEntry.getKey()))) {
>     reflectionProvider.setProperty(paramEntry.getKey(), paramEntry.getValue(), result, extraContext, true);
> }
> {code}
> I have been running a Struts 2 app for 6 years with this change in place.  Just getting around to suggesting it as a patch :)
> It does also look like the documentation for ParameterNameAware would need to be updated to reflect that it can also be used for results, not just actions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira