Mailing-List: contact issues-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@struts.apache.org
Date: Mon, 29 Jul 2013 14:11:48 +0000 (UTC)
From: "Bruce Phillips (JIRA)" <jira@apache.org>
To: issues@struts.apache.org
Message-ID: <JIRA.12657072.1373464122167.128697.1375107108991@arcas>
In-Reply-To: <JIRA.12657072.1373464122167@arcas>
References: <JIRA.12657072.1373464122167@arcas>
Subject: [jira] [Resolved] (WW-4137) Parameter warnings being generated in
 logs after 2.3.7 in portlet
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/WW-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruce Phillips resolved WW-4137.
--------------------------------

    Resolution: Fixed

For now I added the following to the JavaDoc for the ParameterNameAware interface so that it matches the JavaDoc for ParametersInterceptor and so
that users will know that ParameterNameAware acceptableParameterName method
can over-ride the parameter checking done by the ParametersInterceptor:


* Using {@link ParameterNameAware} could be dangerous as {@link ParameterNameAware#acceptableParameterName(String)} takes precedence
 * over {@link ParametersInterceptor} which means if ParametersInterceptor excluded given parameter name you can accept it with
 * {@link ParameterNameAware#acceptableParameterName(String)}.
 *
 * The best idea is to define very tight restrictions with ParametersInterceptor and relax them per action with
 * {@link ParameterNameAware#acceptableParameterName(String)}
                
> Parameter warnings being generated in logs after 2.3.7 in portlet
> -----------------------------------------------------------------
>
>                 Key: WW-4137
>                 URL: https://issues.apache.org/jira/browse/WW-4137
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Portlet
>    Affects Versions: 2.3.7, 2.3.8, 2.3.12, 2.3.14, 2.3.14.1, 2.3.14.2, 2.3.14.3, 2.3.15
>         Environment: liferay portal running in tomcat
>            Reporter: Shawn Andrews
>            Assignee: Bruce Phillips
>            Priority: Minor
>             Fix For: 2.3.16
>
>
> I tried to migrate some portlets from 2.3.4  to 2.3.7 (actually to 2.3.15 but have found that the problem starts in 2.3.7)
> What happens is there is now a warning in the logs whenever I execute an action.
> 09:33:35,327 WARN  [OgnlValueStack:60] Error setting expression 'struts.portlet.action' with value '[Ljava.lang.String;@78f28bba'
> ognl.OgnlException: source is null for getProperty(null, "portlet")
> It seems that in older versions of struts portlet plugin this parameter use to be taken out,  since I believe it is used by struts2 to know what action to execute, but should maybe not be stored in the OGNL stack.   My guess is that this has to do with no field called 'portlet'  with property 'action' in my action class existing to place the expression.
> In version 2.3.4.1 and previous this was not an issue. Maybe the portlet interceptor was taking this parameters out before it was placed into OGNL, and now it is being left?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira