Return-Path: X-Original-To: apmail-struts-issues-archive@minotaur.apache.org Delivered-To: apmail-struts-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 59BE0100B8 for ; Fri, 12 Jul 2013 07:17:52 +0000 (UTC) Received: (qmail 61652 invoked by uid 500); 12 Jul 2013 07:17:51 -0000 Delivered-To: apmail-struts-issues-archive@struts.apache.org Received: (qmail 61593 invoked by uid 500); 12 Jul 2013 07:17:51 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 61148 invoked by uid 99); 12 Jul 2013 07:17:50 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Jul 2013 07:17:50 +0000 Date: Fri, 12 Jul 2013 07:17:50 +0000 (UTC) From: "Lukasz Lenart (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (WW-4119) Wasted work in RefreshModelBeforeResult.beforeResult() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WW-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart resolved WW-4119. ------------------------------- Resolution: Fixed Assignee: Lukasz Lenart Patch applied, thanks! > Wasted work in RefreshModelBeforeResult.beforeResult() > ------------------------------------------------------ > > Key: WW-4119 > URL: https://issues.apache.org/jira/browse/WW-4119 > Project: Struts 2 > Issue Type: Bug > Affects Versions: 2.3.14.3 > Environment: any > Reporter: Adrian Nistor > Assignee: Lukasz Lenart > Labels: patch, performance > Fix For: 2.3.16 > > Attachments: patch.diff > > > The problem appears in version 2.3.14.3 and in revision 1495522. I > attached a one-line patch that fixes it. This problem and the > attached patch are similar to the previously fixed WW-4115 and its > patch. > In method "RefreshModelBeforeResult.beforeResult", the loop over > "root" should break immediately after "needsRefresh" is set to > "false". All the iterations after "needsRefresh" is set to "false" do > not perform any useful work, at best they just set "needsRefresh" > again to "false". -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira