struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shawn Andrews (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4137) Parameter warnings being generated in logs after 2.3.7 in portlet
Date Tue, 23 Jul 2013 15:20:48 GMT

    [ https://issues.apache.org/jira/browse/WW-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13716474#comment-13716474
] 

Shawn Andrews commented on WW-4137:
-----------------------------------

Lukasz, 
No this is not in dev mode. 
And thanks for the explanation, I now understand what is cauing my issue. I also just noticed
that the params I was blacklisting, was no longer being blacklisted in 2.3.7 because of the
change you mentioned. in 2.3.4 and previous using the ParameterNameAware allowed to blacklist
stuff, now it behaves a lot differently since it seems to only be triggered for things that
are already blacklisted using a different method (which is I guess the params.excludeParams
parameter).  
I was using this method because I did not know about the excludeParams parameter,  now that
I do, I will get rid of all the ParameterNameAware stuff since it no longer does what I want
it to do.

Bruce, 
Thanks for your help, the code suggestion you made would work to remove the warning, but since
the ParameterNameAware no longer does what it use to do, I will be just adding my blacklist
to params.excludeParams instead and getting rid of the ParameterNameAware stuff. 
I agree that it might be a good idea to add some stuff to ParameterNameAware to explain that
it no longer really functions as a blacklist, and instead functions as an override on the
excludeParams blacklist.

As far as I am concerned the issue is closed. But I will leave it to you to close incase there
is anything else you want to add.

Thanks, 
  Shawn
                
> Parameter warnings being generated in logs after 2.3.7 in portlet
> -----------------------------------------------------------------
>
>                 Key: WW-4137
>                 URL: https://issues.apache.org/jira/browse/WW-4137
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Portlet
>    Affects Versions: 2.3.7, 2.3.8, 2.3.12, 2.3.14, 2.3.14.1, 2.3.14.2, 2.3.14.3, 2.3.15
>         Environment: liferay portal running in tomcat
>            Reporter: Shawn Andrews
>            Assignee: Bruce Phillips
>            Priority: Minor
>             Fix For: 2.3.16
>
>
> I tried to migrate some portlets from 2.3.4  to 2.3.7 (actually to 2.3.15 but have found
that the problem starts in 2.3.7)
> What happens is there is now a warning in the logs whenever I execute an action.
> 09:33:35,327 WARN  [OgnlValueStack:60] Error setting expression 'struts.portlet.action'
with value '[Ljava.lang.String;@78f28bba'
> ognl.OgnlException: source is null for getProperty(null, "portlet")
> It seems that in older versions of struts portlet plugin this parameter use to be taken
out,  since I believe it is used by struts2 to know what action to execute, but should maybe
not be stored in the OGNL stack.   My guess is that this has to do with no field called 'portlet'
 with property 'action' in my action class existing to place the expression.
> In version 2.3.4.1 and previous this was not an issue. Maybe the portlet interceptor
was taking this parameters out before it was placed into OGNL, and now it is being left?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message