struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bruce Phillips (JIRA)" <>
Subject [jira] [Commented] (WW-4137) Parameter warnings being generated in logs after 2.3.7 in portlet
Date Tue, 23 Jul 2013 11:24:48 GMT


Bruce Phillips commented on WW-4137:

Shawn - my comment: "How you are using the ParameterNameAware interceptor, though legal, isn't
really a good practice." was in reference to your statement that you were just having the
"acceptableParameterName' function in the interface always return 'true'"

I'd have to see your logic of how you have implemented the acceptableParameterName method
in your Action class but it sounds like if a parameter name is not in your Black list then
you are having the method return true.  In that case I can understand why you are getting
the warning based on the changes made in 2.3.7.

Given Luskaz comment I still do not see that we need to make a change in the source code.
 Though we may want to expand on the JavaDoc for ParameterNameAware so that people who use
it fully understand the effect of implementing that interface.

> Parameter warnings being generated in logs after 2.3.7 in portlet
> -----------------------------------------------------------------
>                 Key: WW-4137
>                 URL:
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Portlet
>    Affects Versions: 2.3.7, 2.3.8, 2.3.12, 2.3.14,,,, 2.3.15
>         Environment: liferay portal running in tomcat
>            Reporter: Shawn Andrews
>            Assignee: Bruce Phillips
>            Priority: Minor
>             Fix For: 2.3.16
> I tried to migrate some portlets from 2.3.4  to 2.3.7 (actually to 2.3.15 but have found
that the problem starts in 2.3.7)
> What happens is there is now a warning in the logs whenever I execute an action.
> 09:33:35,327 WARN  [OgnlValueStack:60] Error setting expression 'struts.portlet.action'
with value '[Ljava.lang.String;@78f28bba'
> ognl.OgnlException: source is null for getProperty(null, "portlet")
> It seems that in older versions of struts portlet plugin this parameter use to be taken
out,  since I believe it is used by struts2 to know what action to execute, but should maybe
not be stored in the OGNL stack.   My guess is that this has to do with no field called 'portlet'
 with property 'action' in my action class existing to place the expression.
> In version and previous this was not an issue. Maybe the portlet interceptor
was taking this parameters out before it was placed into OGNL, and now it is being left?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message