struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4124) Wasted work in ValidateVisitor.checkXmlAttributes()
Date Sun, 14 Jul 2013 00:05:50 GMT

    [ https://issues.apache.org/jira/browse/WW-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707887#comment-13707887
] 

Hudson commented on WW-4124:
----------------------------

SUCCESS: Integrated in Struts2-JDK6 #749 (See [https://builds.apache.org/job/Struts2-JDK6/749/])
WW-4124 Improves loop (lukaszlenart: rev 1502446)
* /struts/struts2/trunk/plugins/embeddedjsp/src/main/java/org/apache/struts2/jasper/compiler/Validator.java

                
> Wasted work in ValidateVisitor.checkXmlAttributes()
> ---------------------------------------------------
>
>                 Key: WW-4124
>                 URL: https://issues.apache.org/jira/browse/WW-4124
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Embedded JSP
>    Affects Versions: 2.3.14.3
>         Environment: any
>            Reporter: Adrian Nistor
>            Assignee: Lukasz Lenart
>              Labels: patch, performance
>             Fix For: 2.3.16
>
>         Attachments: patch.diff
>
>
> The problem appears in version 2.3.14.3 and in revision 1495522.  I
> attached a one-line patch that fixes it.  This problem and the
> attached patch are similar to the previously fixed WW-4115 and its
> patch.
> In method "ValidateVisitor.checkXmlAttributes", the loop over "nodes"
> should break immediately after "elExpression" and
> "deferredValueIsLiteral" are set to "true".  All the iterations after
> "elExpression" and "deferredValueIsLiteral" are set to "true" do not
> perform any useful work, at best they just set "elExpression" and
> "deferredValueIsLiteral" again to "true".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message