struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4123) Wasted work in MethodFilterInterceptorUtil.applyMethod()
Date Sun, 14 Jul 2013 00:05:49 GMT

    [ https://issues.apache.org/jira/browse/WW-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707884#comment-13707884
] 

Hudson commented on WW-4123:
----------------------------

SUCCESS: Integrated in Struts2-JDK6 #749 (See [https://builds.apache.org/job/Struts2-JDK6/749/])
WW-4123 Improves loops (lukaszlenart: rev 1502447)
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/interceptor/MethodFilterInterceptorUtil.java

                
> Wasted work in MethodFilterInterceptorUtil.applyMethod()
> --------------------------------------------------------
>
>                 Key: WW-4123
>                 URL: https://issues.apache.org/jira/browse/WW-4123
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.3.14.3
>         Environment: any
>            Reporter: Adrian Nistor
>            Assignee: Lukasz Lenart
>              Labels: patch, performance
>             Fix For: 2.3.16
>
>         Attachments: patch.diff
>
>
> The problem appears in version 2.3.14.3 and in revision 1495522.  I
> attached a two-line patch that fixes it.  This problem and the
> attached patch are similar to the previously fixed WW-4115 and its
> patch.
> In method "MethodFilterInterceptorUtil.applyMethod", the loops over
> "includeMethods" and "excludeMethods" should break immediately after
> "needsPatternMatch" is set to "true".  All the iterations after
> "needsPatternMatch" is set to "true" do not perform any useful work,
> at best they just set "needsPatternMatch" again to "true".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message