Mailing-List: contact issues-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@struts.apache.org
Date: Thu, 20 Jun 2013 06:50:21 +0000 (UTC)
From: "Lukasz Lenart (JIRA)" <jira@apache.org>
To: issues@struts.apache.org
Message-ID: <JIRA.12653728.1371654842714.146616.1371711021788@arcas>
In-Reply-To: <JIRA.12653728.1371654842714@arcas>
References: <JIRA.12653728.1371654842714@arcas>
Subject: [jira] [Updated] (WW-4115) Wasted work in
 ValidateVisitor.getJspAttribute()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/WW-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukasz Lenart updated WW-4115:
------------------------------

    Component/s: Plugin - Embedded JSP
    
> Wasted work in ValidateVisitor.getJspAttribute()
> ------------------------------------------------
>
>                 Key: WW-4115
>                 URL: https://issues.apache.org/jira/browse/WW-4115
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Embedded JSP
>    Affects Versions: 2.3.14.3
>         Environment: any
>            Reporter: Adrian Nistor
>              Labels: patch, performance
>             Fix For: 2.3.16
>
>         Attachments: patch.diff
>
>
> The problem appears in version 2.3.14.3 and in revision 1493157.  I
> attached a one-line patch that fixes it.
> In method "ValidateVisitor.getJspAttribute", the loop over
> "el.iterator()" should break immediately after "deferred" is set to
> "true".  All the iterations after "deferred" is set to "true" do not
> perform any useful work, at best they just set "deferred" again to
> "true".
> Method "evaluateExtraParams" in class "ActionError" has a similar loop
> (over "actionMessages"), and this loop breaks immediately after
> "isEmptyList" is set to "false", just like in the proposed patch.
> Other methods (e.g., "DebuggingInterceptor.printContext",
> "FileUploadInterceptor.isNonEmpty", "CollectVisitor.checkSeen",
> "JspDocumentParser.processChars") also have similar loops with similar
> breaks, just like in the proposed patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira