struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrian Nistor (JIRA)" <>
Subject [jira] [Created] (WW-4126) Incorrect behavior for ELSupport.containsNulls()
Date Fri, 21 Jun 2013 21:32:23 GMT
Adrian Nistor created WW-4126:

             Summary: Incorrect behavior for ELSupport.containsNulls()
                 Key: WW-4126
             Project: Struts 2
          Issue Type: Bug
          Components: Plugin - Embedded JSP
    Affects Versions:
         Environment: any
            Reporter: Adrian Nistor
         Attachments: patch2.diff, patch.diff

The incorrect behavior appears in version and in revision
1495522.  I attached a one-line patch (patch.diff) that fixes it.

Method "ELSupport.containsNulls" checks if the "Object[] obj" array
contains nulls like this:

for (int i = 0; i < obj.length; i++) {
    if (obj[0] == null) {
        return true;
return false;

Instead of "obj[0]", the code should be "obj[i]", as in patch.diff.

If indeed the code is intended to check only "obj[0]", then there is
no need for a loop and the entire method body should be only "return
obj[0] == null;" (I attached patch2.diff, though it's unlikely that
this is the correct behavior).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message