struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrian Nistor (JIRA)" <>
Subject [jira] [Created] (WW-4125) Wasted work in Struts1Factory.convertErrors()
Date Fri, 21 Jun 2013 19:31:19 GMT
Adrian Nistor created WW-4125:

             Summary: Wasted work in Struts1Factory.convertErrors()
                 Key: WW-4125
             Project: Struts 2
          Issue Type: Bug
    Affects Versions:
         Environment: any
            Reporter: Adrian Nistor
         Attachments: patch.diff

The problem appears in version and in revision 1495522.  I
attached a simple patch that fixes it.  This problem and the attached
patch are similar to the previously fixed WW-4116 and its patch.

In method "Struts1Factory.convertErrors", the loop over "errors"
should only be executed when "text != null" or "vaction != null" are
"true", because the loop has no side effects when "text != null" and
"vaction != null" are both "false".  Note that "text" and "vaction"
are not modified inside the loop.

The patch just adds one line, the check:

if (text != null || vaction != null) {

The patch looks large because the entire loop is indented one level,
but the above check is the only code added.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message