struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lukasz Lenart (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (WW-4120) Wasted work in ValidateVisitor.isExpression()
Date Sat, 22 Jun 2013 06:38:22 GMT

     [ https://issues.apache.org/jira/browse/WW-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Lukasz Lenart updated WW-4120:
------------------------------

    Fix Version/s: 2.3.16
    
> Wasted work in ValidateVisitor.isExpression()
> ---------------------------------------------
>
>                 Key: WW-4120
>                 URL: https://issues.apache.org/jira/browse/WW-4120
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Embedded JSP
>    Affects Versions: 2.3.14.3
>         Environment: any
>            Reporter: Adrian Nistor
>              Labels: patch, performance
>             Fix For: 2.3.16
>
>         Attachments: patch.diff
>
>
> The problem appears in version 2.3.14.3 and in revision 1495522.  I
> attached a two-line patch that fixes it.  This problem and the
> attached patch are similar to the previously fixed WW-4115 and its
> patch.
> In method "ValidateVisitor.isExpression", the loop over "nodes" should
> break immediately after "elExpression" is set to "true".  All the
> iterations after "elExpression" is set to "true" do not perform any
> useful work, at best they just set "elExpression" again to "true".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message