struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4115) Wasted work in ValidateVisitor.getJspAttribute()
Date Thu, 20 Jun 2013 07:26:26 GMT

    [ https://issues.apache.org/jira/browse/WW-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13688974#comment-13688974
] 

Hudson commented on WW-4115:
----------------------------

Integrated in Struts2-JDK6 #738 (See [https://builds.apache.org/job/Struts2-JDK6/738/])
    WW-4115 Adds break to break immediately after "deferred" is set to "true" (Revision 1494873)

     Result = SUCCESS
lukaszlenart : 
Files : 
* /struts/struts2/trunk/plugins/embeddedjsp/src/main/java/org/apache/struts2/jasper/compiler/Validator.java

                
> Wasted work in ValidateVisitor.getJspAttribute()
> ------------------------------------------------
>
>                 Key: WW-4115
>                 URL: https://issues.apache.org/jira/browse/WW-4115
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Embedded JSP
>    Affects Versions: 2.3.14.3
>         Environment: any
>            Reporter: Adrian Nistor
>            Assignee: Lukasz Lenart
>              Labels: patch, performance
>             Fix For: 2.3.16
>
>         Attachments: patch.diff
>
>
> The problem appears in version 2.3.14.3 and in revision 1493157.  I
> attached a one-line patch that fixes it.
> In method "ValidateVisitor.getJspAttribute", the loop over
> "el.iterator()" should break immediately after "deferred" is set to
> "true".  All the iterations after "deferred" is set to "true" do not
> perform any useful work, at best they just set "deferred" again to
> "true".
> Method "evaluateExtraParams" in class "ActionError" has a similar loop
> (over "actionMessages"), and this loop breaks immediately after
> "isEmptyList" is set to "false", just like in the proposed patch.
> Other methods (e.g., "DebuggingInterceptor.printContext",
> "FileUploadInterceptor.isNonEmpty", "CollectVisitor.checkSeen",
> "JspDocumentParser.processChars") also have similar loops with similar
> breaks, just like in the proposed patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message