struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4094) struts.allowed.action.names inconsistency
Date Thu, 06 Jun 2013 07:32:23 GMT

    [ https://issues.apache.org/jira/browse/WW-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13676802#comment-13676802
] 

Hudson commented on WW-4094:
----------------------------

Integrated in Struts2-JDK6 #725 (See [https://builds.apache.org/job/Struts2-JDK6/725/])
    WW-4095 WW-4094 Changes how pattern is compiled to be once per instance and changes default
regexp to match underscore (Revision 1490165)

     Result = SUCCESS
lukaszlenart : 
Files : 
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/dispatcher/mapper/DefaultActionMapper.java
* /struts/struts2/trunk/core/src/test/java/org/apache/struts2/dispatcher/mapper/DefaultActionMapperTest.java

                
> struts.allowed.action.names inconsistency
> -----------------------------------------
>
>                 Key: WW-4094
>                 URL: https://issues.apache.org/jira/browse/WW-4094
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.3.14.3
>            Reporter: Andreas Sachs
>            Assignee: Lukasz Lenart
>            Priority: Minor
>             Fix For: 2.3.15
>
>
> I think there is a inconsistency in DefaultActionMapper.cleanupActionName
> According to http://struts.apache.org/development/2.x/docs/s2-015.html struts.allowed.action.names
defines a regex the action name must match.
> The default regex is: {noformat}[a-z]*[A-Z]*[0-9]*[.\-_!/]*{noformat}
> I have an action with the name "core_blz"
> This action name does not match the regex (underscore is not at the end)(maybe the default
value should be changed).
> {noformat}DefaultActionMapper reports Action [#0] do not match allowed action names pattern
[#1], cleaning it up!{noformat}
> But the cleaned action name is still core_blz.
> If this function is only to remove suspicious characters, then the warning should not
be displayed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message