struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lukasz Lenart (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (WW-4066) Submitting form with parameters using brackets while devMode=true yields StringIndexOutOfBoundsException
Date Sun, 19 May 2013 19:09:15 GMT

    [ https://issues.apache.org/jira/browse/WW-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13661627#comment-13661627
] 

Lukasz Lenart edited comment on WW-4066 at 5/19/13 7:07 PM:
------------------------------------------------------------

The problem is related to {{prepare}} interceptor and {{modelDriven}} interceptor - first
will call {{prepare()}} method which will create instance of {{ItemSearchCriteria}} in {{ItemSearchAction#prepare()}}
then {{modelDriven}} will push model onto stack.

The problem here is with {{paramsPrepareParamsStack}} where {{modelDriven}} is before {{prepare}}
and model is null in that case and it wont be pushed onto stack and thus produces mentioned
warnings.

I think we could add a new interceptor - {{ModelCreateInterceptor}} - which can be used just
before {{modelDriven}} to create instance of the model - it will delegate to action to instantiate
model.   
                
      was (Author: lukaszlenart):
    The problem is related to {{prepare}} interceptor and {{modelDriven}} interceptor - first
will call {{prepare()}} method which will create instance of {{ItemSearchCriteria}} in {{ItemSearchAction#prepare()}}
then {{modelDriven}} will push model onto stack.

The problem here is with {{paramsPrepareParamsStack}} where {{modelDriven}} is before {{prepare}}
and model is null in that case and it wont be pushed onto stack.
                  
> Submitting form with parameters using brackets while devMode=true yields StringIndexOutOfBoundsException
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WW-4066
>                 URL: https://issues.apache.org/jira/browse/WW-4066
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Actions
>    Affects Versions: 2.3.14
>            Reporter: Chris Cranford
>            Assignee: Lukasz Lenart
>             Fix For: 2.3.15
>
>         Attachments: testcase.zip
>
>
> Our BaseAction which extends ActionSupport overrides the addActionMessage() with the
following:
> {code:java}
> @Override
> public void addActionMessage(String message) {
>   super.addActionMessage(getText(message));
> }
> {code}
> With the above method in place during devMode=true, the following error stack trace occurs:
> {noformat}
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
>   at java.lang.String.substring(String.java:1871)
>   at com.opensymphony.xwork2.util.LocalizedTextUtil.findText(LocalizedTextUtil.java:426)
>   at com.opensymphony.xwork2.util.LocalizedTextUtil.findText(LocalizedTextUtil.java:362)
>   at com.opensymphony.xwork2.TextProviderSupport.getText(TextProviderSupport.java:208)
>   at com.opensymphony.xwork2.TextProviderSupport.getText(TextProviderSupport.java:123)
>   at com.opensymphony.xwork2.ActionSupport.getText(ActionSupport.java:103)
>   at com.setech.dw.common.web.BaseAction.addActionMessage(BaseAction.java:209)
>   at com.opensymphony.xwork2.interceptor.ParametersInterceptor.setParameters(ParametersInterceptor.java:337)
>   at com.opensymphony.xwork2.interceptor.ParametersInterceptor.doIntercept(ParametersInterceptor.java:241)
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message