struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Grobmeier (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4016) Refactor validationType to be an Enum and not a String
Date Sun, 17 Mar 2013 09:14:13 GMT

    [ https://issues.apache.org/jira/browse/WW-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604552#comment-13604552
] 

Christian Grobmeier commented on WW-4016:
-----------------------------------------

Those methods would change:

ValidatorFactory.lookupRegisteredValidatorType(String name)
ValidatorConfig.Builder(String validatorType)

Is that OK from bc point of view?

If yes, the annotation could look like:

ValidatorType.REGEX
ValidatorType.CONDITIONAL_VISITOR
ValidatorType.VISITOR

And so on.

Except, that ValidatorType is already in use (ValidatorType.FIELD, ValidatorType.SIMPLE)

Any other suggestion for that name?
                
> Refactor validationType to be an Enum and not a String
> ------------------------------------------------------
>
>                 Key: WW-4016
>                 URL: https://issues.apache.org/jira/browse/WW-4016
>             Project: Struts 2
>          Issue Type: Sub-task
>          Components: XML Validators
>    Affects Versions: 2.3.12
>            Reporter: Lukasz Lenart
>            Priority: Minor
>             Fix For: 2.3.13
>
>
> Right no validatorType is a simple String in AnnotationValidationConfigurationBuilder
which can lead to mistakes.
> {code:java}
> String validatorType = "regex";
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message