struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lukasz Lenart (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-3956) (nearly) silent failure of filter initialization if struts.action.excludePattern contains invalid regexp
Date Wed, 16 Jan 2013 14:18:12 GMT

    [ https://issues.apache.org/jira/browse/WW-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555067#comment-13555067
] 

Lukasz Lenart commented on WW-3956:
-----------------------------------

Added note about Pattern class usage with link to JavaDoc
https://cwiki.apache.org/confluence/display/WW/Static+Content

How's your test?
                
> (nearly) silent failure of filter initialization if struts.action.excludePattern contains
invalid regexp
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3956
>                 URL: https://issues.apache.org/jira/browse/WW-3956
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Dispatch Filter
>    Affects Versions: 2.3.8
>         Environment: all
>            Reporter: Horváth, Ákos Péter
>             Fix For: 2.3.9
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> If the struts.action.excludePatterns constant contains an invalid regexp (for example,
it begins with a "*"), the dispatcher can't initialize, but only an "Error filterStart" message
will be logged, and the web app won't work. Imho, the expected behavior were a stack trace
or a more descriptive error message.
> The cause of the problem: the buildExcludedPatternList() method of org.apache.struts2.dispatcher.ng.InitOperations
builds a compiled pattern list of the comma-separated patterns given in this constant with
java.util.regex.Pattern.compile() . This emits an IllegalArgumentException or a PatternSyntaxException,
if invalid regexp is given, but this exception somewhere silently disappears on his way to
the log.
> ---------------
> I suggest to make a minimal example in the documentation:
> ".*\.(css|js|gif|png|jpg|html)$" or "^/static/"
> is what most developer want from this constant. For me took hours to investigate this.
Googling for "struts.action.excludePattern" reveals a lot of confusion about this, too. The
greatest source of the confusion is that it isn't clear, and isn't anywhere documented, which
is the exact regexp syntax here to apply. For example: pattern matching or regular expression,
"^" and "$" are valid or not, they are needed or not, "." matches only "." or any character,
etc. I think, the original inaccuracy was committed by sun, when they named a class as "Pattern",
which operates with regexps. What you here can do, is a single-line minimal-example in the
doc, which will explain everything.
> Thank you,
> PH

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message