struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-3927) com.opensymphony.xwork2.interceptor.ParametersInterceptor incorrect message in log
Date Thu, 06 Dec 2012 00:30:59 GMT

    [ https://issues.apache.org/jira/browse/WW-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510971#comment-13510971
] 

Hudson commented on WW-3927:
----------------------------

Integrated in Struts2-JDK5 #11 (See [https://builds.apache.org/job/Struts2-JDK5/11/])
    WW-3927 corrects developer notification (Revision 1417339)

     Result = SUCCESS
lukaszlenart : 
Files : 
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java

                
> com.opensymphony.xwork2.interceptor.ParametersInterceptor incorrect message in log
> ----------------------------------------------------------------------------------
>
>                 Key: WW-3927
>                 URL: https://issues.apache.org/jira/browse/WW-3927
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 2.3.7
>         Environment: centos/tomcat
>            Reporter: Greg Huber
>            Assignee: Lukasz Lenart
>            Priority: Minor
>             Fix For: 2.3.8
>
>
> Hello,
> Think the notifyDeveloper(..) message should be before the return true; statement!
> {code:java}
>     protected boolean isExcluded(String paramName) {
>         if (!this.excludeParams.isEmpty()) {
>             for (Pattern pattern : excludeParams) {
>                 Matcher matcher = pattern.matcher(paramName);
>                 if (matcher.matches()) {
>                   // messsage here?  
>                   return true;
>                 }
>             }
>         }
>         notifyDeveloper("Parameter [#0] is on the excludeParams list of patterns!", paramName);
>         return false;
>     }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message