struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lukasz Lenart (Closed) (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (WW-3461) Don't hold locks as long when creating validators in AnnotationActionValidatorManager
Date Mon, 05 Dec 2011 11:41:40 GMT

     [ https://issues.apache.org/jira/browse/WW-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Lukasz Lenart closed WW-3461.
-----------------------------

    
> Don't hold locks as long when creating validators in AnnotationActionValidatorManager
> -------------------------------------------------------------------------------------
>
>                 Key: WW-3461
>                 URL: https://issues.apache.org/jira/browse/WW-3461
>             Project: Struts 2
>          Issue Type: Improvement
>    Affects Versions: 2.1.6
>            Reporter: Leigh Anderson
>            Assignee: Lukasz Lenart
>             Fix For: 2.3.1
>
>         Attachments: WW-3461.patch, WW-3461.patch, thread_dump-20110615-1324.tar.bz2,
thread_dump-20110617-1253.tar.bz2, validatormanager.patch
>
>
> Under load, the lock held in AnnotationActionValidatorManager.getValidators on validatorCache
becomes contended. This lock is currently held while all the validators are created. The attached
patch reduces the scope of the lock to just doing the cache lookup + taking a defensive copy
of the list of validators for that key.  This improved throughput and latency in our tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message