struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lukasz Lenart <lukaszlen...@apache.org>
Subject Git rebase
Date Thu, 28 Dec 2017 16:59:37 GMT
Hi,

I have started a new thread as this can be important for newcomers. I
spent some time playing with "git rebase" on different repos and these
are my findings:

- use git rebase till nobody interacted with your PR on GitHub
- rebasing and force pushing reorders comments and commits on GitHub
wich means they do not match anymore, this affects also Coveralls as
its comments won't be in proper places (after each push)
- as a rule of thumb Apache doesn't allow changing history of commits


Regards
-- 
Ɓukasz
+ 48 606 323 122 http://www.lenart.org.pl/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message