Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 48A20200D3E for ; Thu, 16 Nov 2017 21:02:16 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 46F7E160BEA; Thu, 16 Nov 2017 20:02:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B379B1609EF for ; Thu, 16 Nov 2017 21:02:15 +0100 (CET) Received: (qmail 10928 invoked by uid 500); 16 Nov 2017 20:02:14 -0000 Mailing-List: contact dev-help@struts.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Struts Developers List" Reply-To: "Struts Developers List" Delivered-To: mailing list dev@struts.apache.org Received: (qmail 10917 invoked by uid 99); 16 Nov 2017 20:02:14 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Nov 2017 20:02:14 +0000 Received: from [10.0.0.100] (unknown [188.34.220.71]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 90D981A036B for ; Thu, 16 Nov 2017 20:02:12 +0000 (UTC) Subject: Re: Squash PR-s To: dev@struts.apache.org References: <981801a3-867d-ef92-d02b-f34c213ab227@apache.org> From: Yasser Zamani Message-ID: <607a533a-46f2-f9bf-a0db-cad7e6b0f4ca@apache.org> Date: Thu, 16 Nov 2017 23:31:59 +0330 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Antivirus: Avast (VPS 171116-10, 16/11/2017), Outbound message X-Antivirus-Status: Clean archived-at: Thu, 16 Nov 2017 20:02:16 -0000 On 11/15/2017 1:26 PM, Lukasz Lenart wrote: > We can use a label or type in directly in the description, > something like "Please squash this PR" Yes, I think as it rarely happens, maybe a new github label is not needed. Instead, when merger feels a squash suitable case then discusses pull requester to squash which commits. I also think we should not squash to only decrease commit counts. Instead, we should honor "easy to track how and why the changes are made, via enough modular commits counts, not more, not less". When squash helps this, then we do it. Regards, Yasser. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org For additional commands, e-mail: dev-help@struts.apache.org