struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yasser Zamani <yasserzam...@apache.org>
Subject Re: [apache/struts-site] Replaces ([a-z]).\n\n~~~~~~~\n([^\n]+)\n~~~~~~~\n(\s[a-z]) with $1 `$2`$3 (c17f6f9)
Date Fri, 24 Nov 2017 10:14:51 GMT
In this case I avoided a PR because I thought to save Łukasz and 
teammates time as I absolutely was sure about both the problem and the 
solution and did not have even 1% doubt about the work.

But now I think that PRs may bring better confidence for team (at least 
from me who is a new committer). I'll keep Łukasz suggestion hereafter :)

Thanks for your support,
Yasser.


On 11/24/2017 1:22 AM, René Gielen wrote:
> +1 for using a "formal" PR workflow - but please take the discussion to 
> the dev@ mailing list. Discussions here don't get promoted to the list - 
> and if it did not happen on the list it did not happen at all per Apache 
> policy!
> 
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub 
> <https://github.com/apache/struts-site/commit/c17f6f963afa2d9dce81990af6a67aeca53d1532#commitcomment-25814575>,



>> On 11/24/2017 0:22 AM, Lukasz Lenart wrote:
>> That's ok. I just start thinking that we should start using PRs on daily basis, even
for the simplest change - that will allow keep things clear and consistent :)
>> 
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub 
>> <https://github.com/apache/struts-site/commit/c17f6f963afa2d9dce81990af6a67aeca53d1532>,



Mime
View raw message