struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lukasz Lenart <lukaszlen...@apache.org>
Subject Re: Squash PR-s
Date Wed, 15 Nov 2017 09:56:23 GMT
2017-11-07 7:17 GMT+01:00 Yasser Zamani <yasser.zamani@live.com>:
> I agree. Good for cases such [1], however, not good for [2] for example
> where commit 1 and 2 should not be squashed as I intentionally separated
> them to enable easier track of changes and concepts.
>
> [1] https://github.com/apache/struts/pull/173
> [2] https://github.com/apache/struts/pull/167

Yeah... it's not always a good idea to Squash commits, I think we need
a common sense and explicitly say that this PR can be squashed instead
of merged. We can use a label or type in directly in the description,
something like "Please squash this PR"


Regards
-- 
Ɓukasz
+ 48 606 323 122 http://www.lenart.org.pl/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message