struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <Christoph.Nenn...@bmw.de>
Subject Re: Squash PR-s
Date Tue, 07 Nov 2017 14:26:47 GMT
let's see how much we agree what common sense is :)


regards,
Christoph



On 11/7/2017 12:16 AM, Aleksandr Mashchenko wrote:
> I suggest we should start to use this option along with the common sense.

I agree. Good for cases such [1], however, not good for [2] for example 
where commit 1 and 2 should not be squashed as I intentionally separated 
them to enable easier track of changes and concepts.

[1] https://github.com/apache/struts/pull/173
[2] https://github.com/apache/struts/pull/167
Mime
View raw message