struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sdutry <...@git.apache.org>
Subject [GitHub] struts pull request #151: WW-4818 change default Multipart validation regex ...
Date Tue, 25 Jul 2017 11:49:47 GMT
Github user sdutry commented on a diff in the pull request:

    https://github.com/apache/struts/pull/151#discussion_r129282110
  
    --- Diff: core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java ---
    @@ -88,7 +88,7 @@
          */
         public static final String REQUEST_POST_METHOD = "POST";
     
    -    public static final String MULTIPART_FORM_DATA_REGEX = "^multipart\\/form-data(;
boundary=[\\-a-zA-Z0-9]{1,70})?";
    +    public static final String MULTIPART_FORM_DATA_REGEX = "^multipart/form-data(; boundary=[0-9a-zA-Z'()+_,\\-./:=?]{1,70})?";
    --- End diff --
    
    you are correct about the `-` needing to be escaped , but that's the only one i escaped.
(they're in the order they're mentioned in RFC1341 (so i moved the `-` backwards in the pattern)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message