Return-Path: <dev-return-68620-archive-asf-public=cust-asf.ponee.io@struts.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 1D1CF200C45
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue, 28 Mar 2017 20:27:01 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 1BB6F160B9B; Tue, 28 Mar 2017 18:27:01 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 60F2A160B6B
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 28 Mar 2017 20:27:00 +0200 (CEST)
Received: (qmail 40051 invoked by uid 500); 28 Mar 2017 18:26:58 -0000
Mailing-List: contact dev-help@struts.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@struts.apache.org>
List-Help: <mailto:dev-help@struts.apache.org>
List-Post: <mailto:dev@struts.apache.org>
List-Id: "Struts Developers List" <dev.struts.apache.org>
Reply-To: "Struts Developers List" <dev@struts.apache.org>
Delivered-To: mailing list dev@struts.apache.org
Received: (qmail 40040 invoked by uid 99); 28 Mar 2017 18:26:58 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Mar 2017 18:26:58 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 4AC9DDFF47; Tue, 28 Mar 2017 18:26:58 +0000 (UTC)
From: lukaszlenart <git@git.apache.org>
To: dev@struts.apache.org
Reply-To: dev@struts.apache.org
References: <git-pr-3-struts-extras@git.apache.org>
In-Reply-To: <git-pr-3-struts-extras@git.apache.org>
Subject: [GitHub] struts-extras pull request #3: added module for extra result types
Content-Type: text/plain
Message-Id: <20170328182658.4AC9DDFF47@git1-us-west.apache.org>
Date: Tue, 28 Mar 2017 18:26:58 +0000 (UTC)
archived-at: Tue, 28 Mar 2017 18:27:01 -0000

Github user lukaszlenart commented on a diff in the pull request:

    https://github.com/apache/struts-extras/pull/3#discussion_r108499879
  
    --- Diff: struts2-custom-results-plugin/pom.xml ---
    @@ -0,0 +1,104 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    + Licensed to the Apache Software Foundation (ASF) under one
    + or more contributor license agreements.  See the NOTICE file
    + distributed with this work for additional information
    + regarding copyright ownership.  The ASF licenses this file
    + to you under the Apache License, Version 2.0 (the
    + "License"); you may not use this file except in compliance
    + with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    + Unless required by applicable law or agreed to in writing,
    + software distributed under the License is distributed on an
    + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + KIND, either express or implied.  See the License for the
    + specific language governing permissions and limitations
    + under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +
    +    <parent>
    +        <groupId>org.apache.struts</groupId>
    +        <artifactId>struts-master</artifactId>
    +        <version>10</version>
    +    </parent>
    +
    +    <modelVersion>4.0.0</modelVersion>
    +
    +    <artifactId>struts2-custom-results-plugin</artifactId>
    +    <version>1.2-SNAPSHOT</version>
    +    <packaging>jar</packaging>
    +    <name>struts2 custom results plugin</name>
    +
    +    <description>
    +        This plugin defines some additional result types
    +    </description>
    +
    +    <properties>
    +        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    +    </properties>
    +
    +    <scm>
    +        <connection>scm:git:git://git.apache.org/struts-extras.git</connection>
    +        <developerConnection>scm:git:https://git-wip-us.apache.org/repos/asf/struts-extras.git</developerConnection>
    +        <url>http://git.apache.org/struts-extras.git</url>
    +        <tag>HEAD</tag>
    +    </scm>
    +
    +    <issueManagement>
    +        <system>JIRA</system>
    +        <url>https://issues.apache.org/jira/browse/WW</url>
    +    </issueManagement>
    +
    +    <ciManagement>
    +        <system>Jenkins</system>
    +        <url>https://builds.apache.org/hudson/view/S-Z/view/Struts</url>
    +        <notifiers>
    +            <notifier>
    +                <type>mail</type>
    +                <configuration>
    +                    <address>dev@struts.apache.org</address>
    +                </configuration>
    +            </notifier>
    +        </notifiers>
    +    </ciManagement>
    +
    +    <dependencies>
    +
    +        <dependency>
    +            <groupId>org.apache.struts</groupId>
    +            <artifactId>struts2-core</artifactId>
    +            <version>2.5.10.1</version>
    +        </dependency>
    +
    +        <dependency>
    +            <groupId>org.apache.logging.log4j</groupId>
    +            <artifactId>log4j-api</artifactId>
    +            <version>2.8</version>
    +        </dependency>
    +        
    +        <dependency>
    +            <groupId>javax.servlet</groupId>
    +            <artifactId>servlet-api</artifactId>
    +            <version>2.4</version>
    +            <scope>provided</scope>
    +        </dependency>
    +
    +    </dependencies>
    +
    +    <build>
    +        <plugins>
    +            <plugin>
    +                <groupId>org.apache.maven.plugins</groupId>
    +                <artifactId>maven-compiler-plugin</artifactId>
    +                <configuration>
    +                    <source>1.6</source>
    +                    <target>1.6</target>
    --- End diff --
    
    If this plugin targets Struts 2.5.x it supposed to be `1.7` - the same as we have in the Core.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org