struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yasserzamani <...@git.apache.org>
Subject [GitHub] struts pull request #118: [WW-4105] OgnlUtil improved in order to only setti...
Date Tue, 14 Feb 2017 18:14:30 GMT
Github user yasserzamani commented on a diff in the pull request:

    https://github.com/apache/struts/pull/118#discussion_r101103182
  
    --- Diff: core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java
---
    @@ -160,7 +160,20 @@ private void copyStack(ActionInvocation invocation, CompoundRoot
root) {
             Map<String, Object> ctxMap = invocation.getInvocationContext().getContextMap();
             for (Object object : list) {
                 if (shouldCopy(object)) {
    -                reflectionProvider.copy(object, invocation.getAction(), ctxMap, prepareExcludes(),
includes);
    +                String actionConfigClassName = invocation.getProxy().getConfig().getClassName();
    --- End diff --
    
    As I guessed, this line does not work when action is a spring bean (`getClassName` returns
the spring bean id, not fully qualified name of class).
    
    Fortunately it works with actions created by convention plugin.
    
    I will be working on it by checking all references which set or get class name. I also
will add some unit tests to check if similar issues occurs in future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message