struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinjmiller <...@git.apache.org>
Subject [GitHub] struts pull request #99: add allowed methods to handleUnknownAction
Date Thu, 09 Jun 2016 21:52:18 GMT
GitHub user justinjmiller opened a pull request:

    https://github.com/apache/struts/pull/99

    add allowed methods to handleUnknownAction

    Prior to strict-method-invocation, the convention plugin would allow for executing results
(JSP) without an associated Action via the ConventionUnknownHandler.handleUnknownAction method.
 This continues to work with SMI disabled but when enabled the allowedMethods list in the
ActionConfig does not get populated which causes a 404.  There was already a member Set hard
coded to the most common methods to which I added "index" used by the REST plugin.  
    
    Ideally, line 224 would use the globalAllowedMethods set from the PackageConfig instead
of a hard coded list but there is currently no associated getter method and I figured it would
be better to discuss adding that functionality via the PR.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/justinjmiller/struts convention-allowedMethods

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/99.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #99
    
----
commit 0d92fd0ee5d4c23aabe7bf3c2ef1b30ff3e5c00d
Author: jumiller <jumiller@utah.gov>
Date:   2016-06-09T21:39:23Z

    add allowed methods to ActionBuilder

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message