struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aleksandr Mashchenko <amashche...@apache.org>
Subject Re: Re: Struts 2.5
Date Fri, 06 May 2016 09:55:01 GMT
 >>2016-05-06 10:19 GMT+02:00 Aleksandr Mashchenko <amashchenko@apache.org>:
 >> Some strange issue here with 2.5.
 >>
 >> Required labels are shown on both sides of the label. Seems like 
both if-s
 >> in xhtml controlheader-core.ftl evaluate to true.
 >>
 >> 
https://github.com/apache/struts/blob/master/core/src/main/resources/template/xhtml/controlheader-core.ftl#L65
 >> and
 >> 
https://github.com/apache/struts/blob/master/core/src/main/resources/template/xhtml/controlheader-core.ftl#L69

 >Hm... really strange, do you have an example?

Using struts2-archetype-blank add requiredLabel="true" to text field in 
login.jsp, run mvn jetty:run, navigate to 
http://localhost:8080/example/Login



 >> Also following commit declared var in Set tag as required which 
breaks some
 >> of the use cases with Set. Going to change it back to optional.
 >>
 >> 
https://github.com/apache/struts/commit/f8718f9187028c20bf1c042a6a7bfaaadd4ec8b8

 >but only for Set, right?

Was able to refactor the code, let's leave var in Set as it is now :)

Still having issue with double required label, though.

---
Regards,
Aleksandr

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message