struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lukasz Lenart <lukaszlen...@apache.org>
Subject Re: beta3 testing
Date Fri, 04 Mar 2016 17:22:06 GMT
Ah.. looks like a regression, I thought it was something else, so I
will try to figure out what's wrong.

2016-03-04 18:19 GMT+01:00 Greg Huber <gregh3269@gmail.com>:
> Seems to be OK now, don't think it was a problem as I have added the
> default stack, which seems what you have to do now.
>
> Cheers Greg
>
> On 4 March 2016 at 16:59, Lukasz Lenart <lukaszlenart@apache.org> wrote:
>
>> I assume it isn't an issue anymore, right?
>>
>>
>> https://issues.apache.org/jira/browse/WW-4605?focusedCommentId=15179528&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15179528
>>
>>
>> Cheers
>> --
>> Łukasz
>> + 48 606 323 122 http://www.lenart.org.pl/
>>
>> 2016-02-14 12:16 GMT+01:00 Greg Huber <gregh3269@gmail.com>:
>> > .....I seem to now have to add myStack everywhere I use STORE messages
>> for
>> > it to work, which is different from the previous implementation.
>> >
>> > <interceptor-ref name="store">
>> >   <param name="operationMode">STORE</param>
>> > </interceptor-ref>
>> > <interceptor-ref name="MyStack" />
>> >
>> > Cheers Greg
>> >
>> >
>> > On 11 February 2016 at 07:23, Lukasz Lenart <lukaszlenart@apache.org>
>> wrote:
>> >
>> >> 2016-02-08 13:50 GMT+01:00 Lukasz Lenart <lukaszlenart@apache.org>:
>> >> > 2016-02-08 13:44 GMT+01:00 Greg Huber <gregh3269@gmail.com>:
>> >> >> I was dong some more testing and noticed that my message store
>> >> interceptor
>> >> >> messages have stopped working.
>> >> >>
>> >> >> There is a check in the
>> >> >> org.apache.struts2.interceptor.MessageStoreInterceptor to see if
the
>> >> >> response has been committed, and if it is skip the messages
>> processing.
>> >> >>
>> >> >> boolean isCommitted =
>> ServletActionContext.getResponse().isCommitted();
>> >> >>
>> >> >> LOG.debug("Response was already committed, cannot store messages!");
>> >> >>
>> >> >> I do not think I am committing any struts stuff so was wondering
if
>> >> >> anything has changed that would?
>> >> >
>> >> > Yes, it's a side effect of this change [1] but I already refactored
>> >> > the code [2] and now it works even with redirects - is it worth to
>> >> > backport it to 2.3.25?
>> >> >
>> >> > [1] https://issues.apache.org/jira/browse/WW-4600
>> >> > [2] https://issues.apache.org/jira/browse/WW-4605
>> >>
>> >> I have ported the same solution to 2.3.25, I hope it won't break
>> anything
>> >> :)
>> >>
>> >>
>> >> Regards
>> >> --
>> >> Łukasz
>> >> + 48 606 323 122 http://www.lenart.org.pl/
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >> For additional commands, e-mail: dev-help@struts.apache.org
>> >>
>> >>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message